Replace println! calls with snapshot tests
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenserblack
force-pushed
the
chore/156/snapshot-tests
branch
from
1fe6c01
to
913e70c
Compare
kurtlawrence
approved these changes
Dec 12, 2023
|
Oh, interesting. The CI environment didn't detect truecolor support by default, causing the snapshot tests to fail. I updated the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #156, this converts the visual tests into things that can be asserted with
cargo test. These can still be visually reviewed withcat path/to/snapshot. This also registers the detected language for*.snapfiles as plain text -- currently, GitHub will detect them as Jest snapshot files and apply a JavaScript-like syntax highlighting otherwise. This also installscargo-instawhen a contributor creates a new codespace.The one
println!in a test that I didn't address is herecolored/src/lib.rs
Line 839 in 682adf8
Since that didn't look like part of the test, but just a snippet to help debug. I was tempted to switch it to a
dbg!call, butdbg!prints theDebugformatting instead of the display formatting.